Johannes Schindelin wrote:
> The function mark_tree_uninteresting() assumed that the tree entries
> are blob when they are not trees. This is not so. Since we do
> not traverse into submodules (yet), the gitlinks should be ignored.
>
> diff --git a/revision.c b/revision.c
> index 931f978..81b5a93 100644
> --- a/revision.c
> +++ b/revision.c
> @@ -69,7 +69,7 @@ void mark_tree_uninteresting(struct tree *tree)
> while (tree_entry(&desc, &entry)) {
> if (S_ISDIR(entry.mode))
> mark_tree_uninteresting(lookup_tree(entry.sha1));
> - else
> + else if (!S_ISGITLINK(entry.mode))
> mark_blob_uninteresting(lookup_blob(entry.sha1));
> }
>
>
Wouldn't it be better to check for what it is, rather than what it is not?
Sam.
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
