On 2024.09.24 13:33, Junio C Hamano wrote: > Torsten Bögershausen <tboegi@xxxxxx> writes: > > > On Tue, Sep 24, 2024 at 10:16:10AM -0700, Junio C Hamano wrote: > >> "Jean-Noël Avila via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes: > >> > >> > Changes since V4: > >> > > >> > * used BRE in sed filter > >> > * rework the processing of three dots > >> ... > >> Josh (or whoever is taking over this week from him at Google), can > >> you see if the breakage you saw that stopped us merging the topic > >> before it causes us trouble on 'master' reproduces with this version > >> (either by running "make doc" on the topic branch by itself, or on > >> 'seen' that merges the topic) in your environment that had trouble > >> with the previous round? > >> > >> It would also be highly appreciated if other macOS users try "make > >> doc" and see the resulting git-init and git-clone documentation > >> pages are reasonable, both for the previous round that has been > >> cooking in 'next' and for this latest round. Inputs from folks on > >> more mainstream platforms with modern asciidoc/asciidoctor toolchain > >> would also help. The more people we have who look at how the new > >> way the synopsis section is written and how the resulting documents > >> get rendered, the more fairly we can assess the value of this topic. > >> > > Here a report from a MacOs user, > > asciidoc --version > > asciidoc 10.2.0 > > > > installed via macports. > > > > No problems seen in the seen branch. > > > > I diffed git-init.html from seen of today against both master and next, > > some (minor) improvements (like GIT_OBJECT_DIRECTORY vs $GIT_OBJECT_DIRECTORY) > > All in all it looks all sensible. > > (and yes, `sed` understands -E) > > Since I haven't pushed out the 'seen' branch with latest iteration, > your sucess report is about the previous iteration that Josh said > "still breaks on MacOS" [*]. The plot thickens... > > Thanks. > > > [Reference] > > * https://lore.kernel.org/git/4ww5v253vz2g4i3z2x3dmgkrot7mcn2qm6ckjcxbyky6yvrozy@mr5hnrsfj6sn/ I finally got the chance to test this version on $DAYJOB's build infrastructure, and I verified that it works (I also got a much more recent version of sed installed).
