Junio C Hamano <gitster@xxxxxxxxx> writes: Sorry, forgot to say one more thing before pressing [SEND]. >> builtin/submodule--helper.c | 7 ++++++- >> 1 file changed, 6 insertions(+), 1 deletion(-) Please add a test or two, that fail without this change (to demonstrate the existing bug) and succeed with this change (to make sure if somebody breaks the code you fixed again in the future, such a breakage is caught). Thanks.