On Wed, Jun 26, 2024 at 11:51:46AM -0700, Junio C Hamano wrote: > Phillip Wood <phillip.wood123@xxxxxxxxx> writes: > > > Sorry if I wasn't clear. "." is considered safe with "safe.directory = > > *" but I was looking at why it was not considered safe when using > > repository paths in safe.directory. > > Ahh, OK. We tell them /home/wood/repo/git is a good repository to > visit, but daemon's call to ensure_valid_ownership() asks "I am in > the '.' directory; does that match /home/wood/repo/git?" > > That sucks. I agree with your idea that we'd need to canonicalize > both before comparing. And it's addressed with 0ed3dde067a5dc5141e3a31d950972f00a08b35d at least since 2.46.1 Thanks Michal