Re: Local git server can't serve https until repos owned by http, can't serve ssh unless repos owned by user after 2.45.1

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: Local git server can't serve https until repos owned by http, can't serve ssh unless repos owned by user after 2.45.1
From: Junio C Hamano <gitster@xxxxxxxxx>
Date: Wed, 26 Jun 2024 11:51:46 -0700
Cc: Michal Suchánek <msuchanek@xxxxxxx>, Johannes Schindelin <Johannes.Schindelin@xxxxxx>, "David C. Rankin" <drankinatty@xxxxxxxxx>, git@xxxxxxxxxxxxxxx
In-reply-to: <aa94be27-60a5-42d9-adcc-f25f9a8d6ae5@gmail.com> (Phillip Wood's message of "Wed, 26 Jun 2024 19:35:32 +0100")
References: <d9a83e5b-5075-47c6-85c8-e0b550cf859b@gmail.com> <xmqq8qz376fb.fsf@gitster.g> <20240617211513.GM19642@kitsune.suse.cz> <20240625072419.GU19642@kitsune.suse.cz> <xmqqr0cl6lxl.fsf@gitster.g> <20240625183411.GW19642@kitsune.suse.cz> <834862fd-b579-438a-b9b3-5246bf27ce8a@gmail.com> <xmqq34oz1shc.fsf@gitster.g> <aa94be27-60a5-42d9-adcc-f25f9a8d6ae5@gmail.com>
User-agent: Gnus/5.13 (Gnus v5.13)

Phillip Wood <phillip.wood123@xxxxxxxxx> writes:

> Sorry if I wasn't clear. "." is considered safe with "safe.directory =
> *" but I was looking at why it was not considered safe when using
> repository paths in safe.directory.

Ahh, OK.  We tell them /home/wood/repo/git is a good repository to
visit, but daemon's call to ensure_valid_ownership() asks "I am in
the '.' directory; does that match /home/wood/repo/git?"  

That sucks.  I agree with your idea that we'd need to canonicalize
both before comparing.

THanks.

Follow-Ups:
- Re: Local git server can't serve https until repos owned by http, can't serve ssh unless repos owned by user after 2.45.1
  - From: Michal Suchánek

References:
- Local git server can't serve https until repos owned by http, can't serve ssh unless repos owned by user after 2.45.1
  - From: David C. Rankin
- Re: Local git server can't serve https until repos owned by http, can't serve ssh unless repos owned by user after 2.45.1
  - From: Junio C Hamano
- Re: Local git server can't serve https until repos owned by http, can't serve ssh unless repos owned by user after 2.45.1
  - From: Michal Suchánek
- Re: Local git server can't serve https until repos owned by http, can't serve ssh unless repos owned by user after 2.45.1
  - From: Michal Suchánek
- Re: Local git server can't serve https until repos owned by http, can't serve ssh unless repos owned by user after 2.45.1
  - From: Junio C Hamano
- Re: Local git server can't serve https until repos owned by http, can't serve ssh unless repos owned by user after 2.45.1
  - From: Michal Suchánek
- Re: Local git server can't serve https until repos owned by http, can't serve ssh unless repos owned by user after 2.45.1
  - From: Phillip Wood
- Re: Local git server can't serve https until repos owned by http, can't serve ssh unless repos owned by user after 2.45.1
  - From: Junio C Hamano
- Re: Local git server can't serve https until repos owned by http, can't serve ssh unless repos owned by user after 2.45.1
  - From: Phillip Wood

Prev by Date: Re: Re* [PATCH v5] describe: refresh the index when 'broken' flag is used
Next by Date: Re: [PATCH] archive: document that --add-virtual-file takes full path
Previous by thread: Re: Local git server can't serve https until repos owned by http, can't serve ssh unless repos owned by user after 2.45.1
Next by thread: Re: Local git server can't serve https until repos owned by http, can't serve ssh unless repos owned by user after 2.45.1
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]