Re: [PATCH 00/20] Fix typos

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 19, 2024 at 4:42 PM Junio C Hamano <gitster@xxxxxxxxx> wrote:
> "Kristoffer Haugsbakk" <kristofferhaugsbakk@xxxxxxxxxxxx> writes:
> > Maybe all of the commits could be combined into one commit with the
> > message “treewide: fix typos”.  But that wasn’t asked for last time.[1]
> > So I dunno.
>
> It depends.  When done carefully to make sure that nothing textually
> conflicts with any topics in flight, a single "treewide" patch is
> slightly nicer.  If nothing conflicts with nothing else, either
> format is fine.  If something have nasty conflicts (e.g., a refactor
> moved the comment with typos far from the original location or even
> to a different file), individual patch form is easier to discard the
> ones that need to wait.
>
> I do not know which case this 20-patch collection falls into.

For what it's worth, I found the submission easier to review as
separate patches because it allowed me to review a small batch, do
something else for a bit, review another batch, do something else,
etc., without losing my place since I deleted the ones I had already
reviewed, so I knew that those remaining in my Inbox were still
pending review.





[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux