On Sat, Nov 10, 2007 at 03:34:35PM -0500, Jeff King wrote: > Your solution leaves me partly disgusted at the hackishness, and partly > delighted at the cleverness. I think the way you have coded it is quite > clear, though, so I don't think anyone is likely to get confused reading > it. I haven't read through it carefully yet, but a tentative Ack from > me. OK, I had a chance to read through your patches more carefully. Assuming that the strbuf offset technique is acceptable (and I think it is worth the increased speed and simplicity), they look great to me. So: Acked-by: Jeff King <peff@xxxxxxxx> -Peff - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html