On Sat, Nov 10, 2007 at 12:12:33PM +0100, René Scharfe wrote: > Yes, the two are independent. I don't like the malloc()'s in your > patch, though, and have cooked up a different one on top of a cleaned up > version of mine. It plays the dirty trick of reading expansions of > repeated placeholders from the strbuf.. Yes, the mallocs would obviously not be necessary for the commit parsing, since we already have a buffer, but I assumed they would be for the abbreviations. Your solution leaves me partly disgusted at the hackishness, and partly delighted at the cleverness. I think the way you have coded it is quite clear, though, so I don't think anyone is likely to get confused reading it. I haven't read through it carefully yet, but a tentative Ack from me. -Peff - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
