On Thu, Sep 12, 2024 at 04:00:11AM -0400, Jeff King wrote:
> But I _think_ all of those details I sent add up to a possible patch
> series. But it probably still makes sense to take your patch here, as it
> unblocks CI in the short term. And then I can build the bigger fix on
> top of that (it touches the same spot, but in the end both end up
> removing that special case).
OK, here's what I came up with. I built it on top of what you have
queued in jc/ci-upload-artifact-and-linux32, but it could be applied
separately (and it should merge OK).
The state after each patch should still pass, but of course each of them
depends on the ones before.
The big downside is discussed in patch 3: we are losing what is probably
the oldest platform we test against. I don't think it's fixable in this
approach, though; the Actions node just won't run on such an old
platform. So the options are:
- hope that they eventually move to a true static node binary
- switch the design entirely; handle docker ourselves, run the actions
in the regular runner-image environment, and then just do the "make
test" bits inside the container
IMHO what's in this series is an OK tradeoff (we are going from an
8-year-old image to a 4-year-old one, but it gets older with each
passing year). If somebody wants to pursue the alternate design above,
be my guest. I'm just trying not to fall into that rabbit hole myself. ;)
[1/4]: ci: drop run-docker scripts
[2/4]: ci: unify ubuntu and ubuntu32 dependencies
[3/4]: ci: use more recent linux32 image
[4/4]: ci: use regular action versions for linux32 job
.github/workflows/main.yml | 12 +++----
ci/install-dependencies.sh | 45 +++++++++++++++-----------
ci/run-docker-build.sh | 66 --------------------------------------
ci/run-docker.sh | 47 ---------------------------
4 files changed, 32 insertions(+), 138 deletions(-)
delete mode 100755 ci/run-docker-build.sh
delete mode 100755 ci/run-docker.sh
-Peff
