Junio C Hamano <gitster@xxxxxxxxx> writes: > Linux32 jobs seem to be getting: > > Error: This request has been automatically failed because it uses a > deprecated version of `actions/upload-artifact: v1`. Learn more: > https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/ > > before doing anything useful. For now, disable the step. > > Ever since actions/upload-artifact@v1 got disabled, mentioning the > offending version of it seems to stop anything from happening. At > least this should run the same build and test. > > See > > https://github.com/git/git/actions/runs/10780030750/job/29894867249 > > for example. > > Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx> > --- > .github/workflows/main.yml | 6 ------ > 1 file changed, 6 deletions(-) I refrain from merging my own patches until somebody else at least comments on them, but I'll make an exception and merge this to 'next', as a few "container" jobs _always_ fail to start otherwise. At least with the step removed, a run without any test failures would tell us that these container tasks are OK, which is much better. If somebody finds a better solution (i.e., a way to extract trash directories of failed tests', with actions/upload-artifact@v1), that can be added later on top. > diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml > index 1ee0433acc..97f9b06310 100644 > --- a/.github/workflows/main.yml > +++ b/.github/workflows/main.yml > @@ -365,12 +365,6 @@ jobs: > with: > name: failed-tests-${{matrix.vector.jobname}} > path: ${{env.FAILED_TEST_ARTIFACTS}} > - - name: Upload failed tests' directories > - if: failure() && env.FAILED_TEST_ARTIFACTS != '' && matrix.vector.jobname == 'linux32' > - uses: actions/upload-artifact@v1 # cannot be upgraded because Node.js Actions aren't supported in this container > - with: > - name: failed-tests-${{matrix.vector.jobname}} > - path: ${{env.FAILED_TEST_ARTIFACTS}} > static-analysis: > needs: ci-config > if: needs.ci-config.outputs.enabled == 'yes'
