On Thu, Sep 05, 2024 at 08:12:58PM +0800, Xing Xin wrote: > At 2024-09-05 19:05:15, "Patrick Steinhardt" <ps@xxxxxx> wrote: > >On Wed, Sep 04, 2024 at 03:49:28PM +0800, Xing Xin wrote: > >> At 2024-09-03 18:09:45, "Patrick Steinhardt" <ps@xxxxxx> wrote: > >> >In the latter case I could see that it may make sense to instead make > >> >this `remote.<name>.serverOption`. This would also remove the unclean > >> > >> I named the new configuration `fetch.serverOption` mainly to follow the > >> `push.pushOption` pattern. Since which server options to support is > >> actually server-specific, using `remote.<name>.serverOption` is a good > >> idea for git-fetch. However, how should we design the configuration for > >> git-ls-remote or git-clone, if we wanna provide all of them with a > >> default list of server options to send? > > > >As mentioned in another reply, I think that putting this into the remote > >configuration "remote.*.serverOption" might be a better solution, as it > >also brings you the ability to set this per remote by default. > > I agree that using "remote.*.serverOption" is better. In fact, I also > think "push.pushOption" would be better as "remote.*.pushOption". What I'm > contemplating is whether we need to add a configuration for a default > list of server options, so that when "remote.origin.serverOption" is not > present, we can fall back to use that as default. Junio proposed in [1] to introduce `[remote "*"]` syntax to supply default values to all remotes. You could pick up that proposal and implement it as part of your patch series. I also have to agree that "push.pushOption" would be way more sensible if it was configured per remote. I think it would be sensible to also introduce "remote.*.pushOption" in the same way and have it override the default value of "push.pushOption" if present. So the precedence order would become (from high to low): - remote.someRemote.pushOption - remote."*".pushOption - push.PushOption This should be backwards compatible, too. Patrick [1]: <xmqq5xrcn2k1.fsf@gitster.g>
