On Sat, Nov 10, 2007 at 09:06:28AM +0000, Junio C Hamano wrote:
> Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes:
>
> > if (signoff) {
> > ...
> > + strbuf_init(&sob, 0);
> > + strbuf_addstr(&sob, sign_off_header);
> > + strbuf_addstr(&sob, git_committer_info(1));
> > + p = strrchr(sob.buf, '>');
> > + if (p)
> > + strbuf_setlen(&sob, p + 1 - sob.buf);
> > + strbuf_addch(&sob, '\n');
> > +
> > + for (i = sb.len - 1; i > 0 && sb.buf[i - 1] != '\n'; i--)
> > + ; /* do nothing */
> > + if (prefixcmp(sb.buf + i, sob.buf))
> > + strbuf_addbuf(&sb, &sob);
> > }
>
> At this point doesn't this leak sob.buf?
It does, strbuf_addbuf copies `sob` but doesn't release resources.
--
·O· Pierre Habouzit
··O madcoder@xxxxxxxxxx
OOO http://www.madism.org
Attachment:
pgpfX26c3tTy0.pgp
Description: PGP signature
