Re: [PATCH 01/20] path: expose `do_git_path()` as `repo_git_pathv()`

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 24/08/07 08:56AM, Patrick Steinhardt wrote:
> We're about to move functions of the "path" subsytem that do not use a

s/subsytem/subsystem/

> `struct repository` into "path.h" as static inlined functions. This will
> require us to call `do_git_path()`, which is internal to "path.c".

So in other words, functions leveraging `the_repository` in "path.c" are
going to be moved to "path.h". Since these functions depend on
`do_git_path()`, we need to expose it. Makes sense so far.

> Expose the function as `repo_git_pathv()` to prepare for the change.
> 
> Signed-off-by: Patrick Steinhardt <ps@xxxxxx>
[snip]
> +/*
> + * Print a path into the git directory of repository `repo` into the provided
> + * buffer.
> + */
> +void repo_git_pathv(const struct repository *repo,
> +		    const struct worktree *wt, struct strbuf *buf,
> +		    const char *fmt, va_list args);
> +

Out of curiousity, do we have a preferred convention for how functions
accepting `va_list` are named? Searching through the codebase, I don't
see a ton of consistency, but I have noticed examples prefixed with "v".




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux