Patrick Steinhardt <ps@xxxxxx> writes: > I can see two options: > > 1. Refactor these interfaces such that they take a file descriptor as > input that they are writing to. This would allow us to exercise > that the output is correct. > > 2. Rip out this function. I don't think this functionality should be > part of the library in the first place, and it really only exists > because of "reftable/dump.c". > > I think the latter is the better option. The functionality exists to > drive `cmd__dump_reftable()` in our reftable test helper. We should > likely make the whole implementation of this an internal implementation > detail and not expose it. Thanks for a review. Are there anything other than removing this step that this series needs?
