On Wed, 17 Jul 2024 at 17:19, Karthik Nayak <karthik.188@xxxxxxxxx> wrote: > > Chandra Pratap <chandrapratap3519@xxxxxxxxx> writes: > > > reftable/tree_test.c exercises the functions defined in > > reftable/tree.{c, h}. Migrate reftable/tree_test.c to the unit > > testing framework. Migration involves refactoring the tests to use > > the unit testing framework instead of reftable's test framework and > > renaming the tests to align with unit-tests' standards. > > > > Nit: it would be nice to mention that this commit copies it over as-is > (mostly) and the upcoming commits do refactoring. This would really help > reviewers. I do mention that in the patch cover letter, specifically this paragraph: > The first patch in the series is preparatory cleanup, the second patch > moves the test to the unit testing framework, and the rest of the patches > improve upon the ported test. Would it be better if I transport that here? ----[snip]----