phillip.wood123@xxxxxxxxx writes: > On 13/07/2024 13:30, Karthik Nayak wrote: >> Phillip Wood <phillip.wood123@xxxxxxxxx> writes: > > >>> I'm a bit confused - what does "allowed to fail" mean? We don't have any >>> automated requirements on the CI passing. We don't want to train >>> contributors to routinely ignore CI failures but if they don't get a >>> notification that this job failed how do they know to correct the >>> formatting? >>> >> >> Well, it mostly means that the CI would show the style-check job as >> failed, but the overall pipeline would be successful. > > Ah, I didn't know that was a possibility - do users still get emails > about the failed job? > I know in GitLab, users _wouldn't_ get an email. This would be a nice intermediate step, but I think it is still okay. >> We want to ideally >> fail the pipeline too, but I'm being careful to not disrupt things >> suddenly and I think once we see what false positive rate is and once we >> fine tune this settings maybe over the next release or so, we can >> enforce this. > > Starting gently to get some experience with the auto formatter sounds > sensible. Thanks for working on this, I really hope that once we've got > more experience with clang format we can figure out how to enable it > unconditionally. > > Best Wishes > > Phillip Just to clarify, enabling an auto-formatter would always be left to the user. From the project's perspective, the goal would be to have checks to notify us (us as in the Git project) if a particular patch series fails to comply to our standards. This is done by enforcing the CI rule _eventually_. Users can also benefit from this if they use the CI for development purposes. One good example being users of GitGitGadget, where they would be notified of failures in the CI. Another example is contributions coming from GitLab, where our team uses the CI before sending patches upstream. Since the Git project already comes with a '.clang-format', users can already enable auto-formatting on their end. I know the clangd LSP already supports this. ;) Thanks Karthik
Attachment:
signature.asc
Description: PGP signature
