On 13/07/2024 13:30, Karthik Nayak wrote:
Phillip Wood <phillip.wood123@xxxxxxxxx> writes:
>
I'm a bit confused - what does "allowed to fail" mean? We don't have any
automated requirements on the CI passing. We don't want to train
contributors to routinely ignore CI failures but if they don't get a
notification that this job failed how do they know to correct the
formatting?
Well, it mostly means that the CI would show the style-check job as
failed, but the overall pipeline would be successful.
Ah, I didn't know that was a possibility - do users still get emails
about the failed job?
We want to ideally
fail the pipeline too, but I'm being careful to not disrupt things
suddenly and I think once we see what false positive rate is and once we
fine tune this settings maybe over the next release or so, we can
enforce this.
Starting gently to get some experience with the auto formatter sounds
sensible. Thanks for working on this, I really hope that once we've got
more experience with clang format we can figure out how to enable it
unconditionally.
Best Wishes
Phillip
