On Wed, Jul 10, 2024 at 02:04:15PM -0700, Junio C Hamano wrote: > shejialuo <shejialuo@xxxxxxxxx> writes: > > > The static function "report" provided by "fsck.c" aims at checking fsck > > error type and calling the callback "error_func" to report the message. > > However, "report" function is only related to object database which > > cannot be reused for refs. In order to provide a unified interface which > > can report either objects or refs, create a new function "vfsck_report" > > by adding "checked_ref_name" parameter following the "report" prototype. > > Instead of using "...", provide "va_list" to allow more flexibility. > > Like strbuf_vinsertf(), it is a good idea to have "v" in the name of > a function that takes va_list, but fsck_vreport() would probably be > a better name here. Arguably, the original report() is misnamed (as > a printf-like function that takes format string, it probably would > have wanted to be reportf() instead), but unless we are fixing that > at the same time, calling this fsck_vreportf() would probably be too > much. Consistently misnaming it by omitting the final "f" would be > fine. > Yes，I will rename it to "fsck_vreport". > At this step it is still not clear if the previous step was really > needed; you have this "v" thing that is designed to be usable by > both reporting issues around objects and issues around refs, but we > will hopefully see why when we read later patches.
