On Friday, June 21, 2024 3:20 PM, Junio C Hamano wrote: >To: rsbecker@xxxxxxxxxxxxx >Cc: 'Randall S. Becker' <the.n.e.key@xxxxxxxxx>; git@xxxxxxxxxxxxxxx; Randall >Becker <randall.becker@xxxxxxxxxxxx> >Subject: Re: [PATCH v0 1/1] Teach git version --build-options about zlib+libcurl > >Junio C Hamano <gitster@xxxxxxxxx> writes: > >> At least for build on platforms without libcURL, you build with >> NO_CURL defined, i.e. "make NO_CURL=NoThanks", and anything that >> includes <curl/curl.h> is *NOT* compiled at all, avoiding the broken >> build. > >Unfortunately, we cannot use the same trick, i.e. "Makefile knows not to even >compile when NO_CURL is set", as this change is to help.c and we cannot say "if you >do not have libcURL, you do not get any help" ;-) > > #ifndef NO_CURL > #include "git-curl-compat.h" > #endif > >may be a simplest workaround, as Makefile does this: > > ifdef NO_CURL > BASIC_CFLAGS += -DNO_CURL > ... That makes sense
