Re: [PATCH v0 1/1] Teach git version --build-options about zlib+libcurl

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Junio C Hamano <gitster@xxxxxxxxx> writes:

> At least for build on platforms without libcURL, you build with
> NO_CURL defined, i.e. "make NO_CURL=NoThanks", and anything that
> includes <curl/curl.h> is *NOT* compiled at all, avoiding the broken
> build.

Unfortunately, we cannot use the same trick, i.e. "Makefile
knows not to even compile when NO_CURL is set", as this change is to
help.c and we cannot say "if you do not have libcURL, you do not get
any help" ;-)

        #ifndef NO_CURL
        #include "git-curl-compat.h"
        #endif

may be a simplest workaround, as Makefile does this:

        ifdef NO_CURL
                BASIC_CFLAGS += -DNO_CURL
		...





[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux