There are several varargs functions that take either NULL-terminated list of parameters, or printf-like format followed by list of parameters, that are not declared as such with __attributes__(()). Adding such a missing attribute to trace2_region_enter_printf() revealed that an existing call to it was trying to format a value of type size_t using "%d", which is not such an excellent idea. Other functions that were lacking attributes fortunately did not have any broken existing callers. Junio C Hamano (4): __attribute__: trace2_region_enter_printf() is like "printf" __attribute__: remove redundant __attribute__ declaration for git_die_config() __attribute__: mark some functions with LAST_ARG_MUST_BE_NULL __attribute__: add a few missing format attributes add-patch.c | 1 + attr.h | 2 ++ config.c | 1 - hook.h | 1 + mem-pool.h | 1 + run-command.c | 3 ++- scalar.c | 2 ++ trace2.h | 1 + wt-status.c | 1 + 9 files changed, 11 insertions(+), 2 deletions(-) -- 2.45.2-445-g1b76f06508