On Wed, Jun 05, 2024 at 10:53:53AM +0200, René Scharfe wrote:
> Am 04.06.24 um 12:13 schrieb Jeff King:
> > b. Now that we don't need the original string to hang around, we can
> > get rid of the "filebuf" mechanism entirely
>
> Right. This patch does remove its use from dir.c, but leaves it in dir.h:
Hmph. I'm not sure how I managed that. I definitely removed it from the
struct definition in order to find all of the sites that mention it, but
somehow that didn't end up in the final patch. Thanks for noticing.
It looks like the topic hasn't hit next yet. Rather than send a v3 with
this tiny change, Junio, do you mind squashing this into patch 6 (it's
d465adca6d in your tree)?
---
diff --git a/dir.h b/dir.h
index c8ff308fae..1398a53fb4 100644
--- a/dir.h
+++ b/dir.h
@@ -95,9 +95,6 @@ struct pattern_list {
int nr;
int alloc;
- /* remember pointer to exclude file contents so we can free() */
- char *filebuf;
-
/* origin of list, e.g. path to filename, or descriptive string */
const char *src;
-Peff
