"brian m. carlson" <sandals@xxxxxxxxxxxxxxxxxxxx> writes: > On 2024-05-28 at 02:13:55, Joey Hess wrote: >> Johannes Schindelin wrote: >> Writing objects: 100% (3/3), 324 bytes | 324.00 KiB/s, done. >> Total 3 (delta 0), reused 0 (delta 0), pack-reused 0 (from 0) >> remote: error: object ea461949b973a70f2163bb501b9d74652bde9e30: symlinkPointsToGitDir: symlink target points to git dir >> remote: fatal: fsck error in pack objects >> error: remote unpack failed: unpack-objects abnormal exit >> To ../bar.git >> ! [remote rejected] master -> master (unpacker error) >> error: failed to push some refs to '../bar.git' >> >> So I guess that the WARN doesn't work like you expected it to in this case of >> receive.fsckobjects checking. > > Then my guess is that this will affect most forges. FWIW, it is detected as "error" according to the above. In any case, a33fea08 (fsck: warn about symlink pointing inside a gitdir, 2024-04-10) adds two ERRORs, in addition to two WARNs: + FUNC(SYMLINK_TARGET_MISSING, ERROR) \ + FUNC(SYMLINK_TARGET_BLOB, ERROR) \ + FUNC(SYMLINK_TARGET_LENGTH, WARN) \ + FUNC(SYMLINK_POINTS_TO_GIT_DIR, WARN) \ so "they are only warnings and won't break" is not quite what I see in the change, but what is causing the above error does look like the one that is marked as WARN in the patch. Thanks.
