On Wed, May 22, 2024 at 4:47 AM John Paul Adrian Glaubitz <glaubitz@xxxxxxxxxxxxxxxxxxx> wrote: > On Wed, 2024-05-22 at 01:32 -0700, Carlo Marcelo Arenas Belón wrote: > > On Mon, May 20, 2024 at 03:01:30PM UTC, Eric Sunshine wrote: > > > From: John Paul Adrian Glaubitz <glaubitz@xxxxxxxxxxxxxxxxxxx> > > > > > > On SPARC systems running Linux, individual processors are denoted with > > > "CPUnn:" in /proc/cpuinfo instead of the usual "processor NN:". > > > > not sure if worth a reroll, but the "usual" syntax is "processor : NN" > > the regexp used checks for numbers before the colon to account for the > > syntax used on s390x which is the only one with numbers before the colon. > > Good catch. I think this can just be fixed by whoever commits the patches > or is that done automatically? Inclusion of the word "usual" is such a minor flaw in the commit message that I doubt it warrants a reroll and the associated cost on reviewers and on the maintainer (Junio), especially since it does not negatively impact the intent conveyed by the commit messages nor the correctness of the actual patch. As such, I'm not worried about it. Whether Junio reads this and wants to correct it in his tree is up to him, of course.
