On Wed, May 15, 2024 at 11:05:18AM +0200, Patrick Steinhardt wrote:
> > diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c
> > index 10e69fdc8e..26a6d0d791 100644
> > --- a/builtin/pack-objects.c
> > +++ b/builtin/pack-objects.c
> > @@ -1245,7 +1245,6 @@ static void write_pack_file(void)
> > uint32_t nr_remaining = nr_result;
> > time_t last_mtime = 0;
> > struct object_entry **write_order;
> > - struct bitmap_writer bitmap_writer;
> >
> > if (progress > pack_to_stdout)
> > progress_state = start_progress(_("Writing objects"), nr_result);
> > @@ -1315,6 +1314,7 @@ static void write_pack_file(void)
> > if (!pack_to_stdout) {
> > struct stat st;
> > struct strbuf tmpname = STRBUF_INIT;
> > + struct bitmap_writer bitmap_writer;
> > char *idx_tmp_name = NULL;
> >
> > /*
>
> Nit: we could have avoided moving the struct if it was introduced in
> this spot in the preceding patch.
Ugh, I meant to move the declaration here in the previous patch, but
apparently didn't. I don't think it's worth sending another round just
to fix that minor issue, but happy to do so if you feel strongly.
Thanks,
Taylor
