Junio C Hamano <gitster@xxxxxxxxx> writes: > From: Patrick Steinhardt <ps@xxxxxx> > > The git-hash-object(1) command allows users to hash an object even > without a repository. Starting with c8aed5e8da (repository: stop setting > SHA1 as the default object hash, 2024-05-07), this will make us hit an > uninitialized hash function, which subsequently leads to a segfault. > > Fix this by falling back to SHA-1 explicitly when running outside of a > Git repository. Users can use GIT_DEFAULT_HASH_ALGORITHM environment to > specify what hash algorithm they want, so arguably this code should not > be needed. > > Signed-off-by: Patrick Steinhardt <ps@xxxxxx> > Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx> > --- > builtin/hash-object.c | 3 +++ > t/t1007-hash-object.sh | 6 ++++++ > t/t1517-outside-repo.sh | 2 +- > 3 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/builtin/hash-object.c b/builtin/hash-object.c > index 82ca6d2bfd..c767414a0c 100644 > --- a/builtin/hash-object.c > +++ b/builtin/hash-object.c > @@ -123,6 +123,9 @@ int cmd_hash_object(int argc, const char **argv, const char *prefix) > else > prefix = setup_git_directory_gently(&nongit); > > + if (nongit && !the_hash_algo) > + repo_set_hash_algo(the_repository, GIT_HASH_SHA1); This is slightly different from your version, which always used SHA-1 when nongit is true, in the hope that it would make it more useful if the user can say "GIT_DEFAULT_HASH_ALGORITHM=sha256 git hash-objects" outside a repository. I am not 100% convinced it is better or we rather should aim for predictability that you'd always and only get SHA-1 outside a repository.
