Patrick Steinhardt <ps@xxxxxx> writes: > The reftable format only supports block sizes up to 16MB. When the > writer is being passed a value bigger than that it simply calls > abort(3P), which isn't all that helpful due to the lack of a proper > error message. > > Improve this by calling `BUG()` instead. As a "git" person, I do not mind this at all. But doesn't the reftable/ library codebase want to avoid things like BUG() that are very much tied to our codebase, for the same reason as it avoids things like xmalloc(), xcalloc(), and ALLOC_GROW()? We may have crossed the bridge long time ago, though. We see a handful calls to BUG() already inside reftable/ directory.
