Patrick Steinhardt <ps@xxxxxx> writes: > We have a static variable in the reftable writer code that is merely > used to initialize the `last_key` of the writer. Convert the code to > instead use `strbuf_init()` and drop the variable. Nice. There is no guarantee that a structure assignment of a just-initialized empty strbuf to another will stay to be a trouble free operation, and using an explicit _init() call is the right thing to do.
