2007/11/5, Junio C Hamano <gitster@xxxxxxxxx>: > Shawn Bohrer <shawn.bohrer@xxxxxxxxx> writes: > > > +static int show_only = 0; > > +static int remove_directories = 0; > > +static int quiet = 0; > > +static int ignored = 0; > > +static int ignored_only = 0; > > Please do not explicitly initialize static variables to zero. Is it really needed to declare those variables outside of a function in this case? This scheme makes difficult reusing the code from other builtins, rewriting it for libification, calling it many times, or even understand if they were declared that way with a purpose or not. I just don't know why they are that way in this case, is there a reason for it? - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html