On Mon, 5 Nov 2007, Pierre Habouzit wrote: > On Mon, Nov 05, 2007 at 03:35:34AM +0000, Daniel Barkalow wrote: > > Signed-off-by: Daniel Barkalow <barkalow@xxxxxxxxxxxx> > > --- > > I mostly did this and the next one for practice with the API. I'm > > impressed that "git fetch -vv" is even handled correctly without anything > > special. Now that I've done it, assuming I did it right, it might as well > > get added to the series. > > I believe the same patches (or very similar ones) are in pu but are > not in next yet because they conflict with the builtin-fetch recent > series. > > see http://git.madism.org/?p=git.git;a=blobdiff;f=builtin-fetch.c;h=12b1c4;hp=6b1750d;hb=7407915;hpb=61610e6 Ah, okay, forgot to look there. In any case, I was mostly looking for what mistakes I shouldn't make in future conversions. > > + OPT_BOOLEAN('q', "quiet", &quiet, "fetch silently"), > > there is an OPT__QUIET(&quiet) for this one. > > > + i = 1; > > if (i < argc) { > > int j = 0; > > refs = xcalloc(argc - i + 1, sizeof(const char *)); > > this is wrong, you meant i = 0, and frankly, it's better to just strip > i altogether. I didn't consume the remote name's slot, and started at the next one. But you're right that it's probably nicest to do to *argv++, argc-- thing and be zero-based for the list afterwards. I think I need the 'i' in this case, because the names get somewhat converted from the exact list given. -Daniel *This .sig left intentionally blank* - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
