On Mon, Nov 05, 2007 at 03:35:34AM +0000, Daniel Barkalow wrote: > I mostly did this and the next one for practice with the API. I'm > impressed that "git fetch -vv" is even handled correctly without anything > special. About that: OPTION_BOOLEAN increments the associated variable, to support this case specifically. The last thing that really miss in parse-options is a way to recurse into a sub-array of struct option, to be able to port the generic diff and revision arguments. Though, there is a difficulty here that I've not yet found how to circumvent tastefully: right now options take an absolute pointer to _the_ variable that will be filled with values. I need to be able to relocate such a structure for sub-arrays for quite obvious reasons, and that is quite hard to achieve without hazardous APIs. I currently lean in the direction of simply memdup-ing the array and do fix-ups on *values pointers. Though how to do that in a graceful way is not obvious to me yet :) This is the issue that currently prevents me from migrating any log and diff based, though git diff -wbBCM that doesn't work is irritating me more and more every day, so I'm confident I'll find a solution soon :) -- ·O· Pierre Habouzit ··O madcoder@xxxxxxxxxx OOO http://www.madism.org
Attachment:
pgpZsoLQrTl03.pgp
Description: PGP signature
