Hello James, James Liu <james@xxxxxxxxxxx> writes: > Hi, > > Thank you all for the comprehensive feedback. This is v4 of the patch > series to introduce a --no-advice option for silencing advice hints. > > The main changes are: > > - Two preliminary commits to reorder/clean up the options documentation > and usage string. > - Caching the value of GIT_ADVICE. > - Adding tests which explicitly set GIT_ADVICE to false and true. > > Cheers, > James > This version looks good to me. Thanks Karthik > James Liu (3): > doc: clean up usage documentation for --no-* opts > doc: add spacing around paginate options > advice: add --no-advice global option > > Documentation/git.txt | 18 +++++++----- > advice.c | 7 +++++ > environment.h | 7 +++++ > git.c | 11 +++++-- > t/t0018-advice.sh | 68 +++++++++++++++++++++++++++++++++++++++++++ > 5 files changed, 101 insertions(+), 10 deletions(-) > > Range-diff against v3: > 1: 55d5559586 < -: ---------- advice: add --no-advice global option > -: ---------- > 1: ae3f45dadc doc: clean up usage documentation for --no-* opts > -: ---------- > 2: 1b0019026a doc: add spacing around paginate options > -: ---------- > 3: 31e73e6c0e advice: add --no-advice global option > -- > 2.44.0
Attachment:
signature.asc
Description: PGP signature
