On 16/04/2024 16:22, Junio C Hamano wrote:
Phillip Wood <phillip.wood123@xxxxxxxxx> writes:
That flow of thought makes sort-of sense, if the choices that are
offered are too numerous (say, around a dozen or more), but with the
current command set, I am not sure if this change is an improvement
(note: I did not say "I do not think that"---I simply am not sure).
The complete list of help is 15 lines long (we don't always print
everything but if you're in the middle of staging several hunks from
the same file we do)
Ah, OK. Even though I was the one who stole this feature from
elsewhere, I forgot that we had that many commands, and it makes the
decision a lot simpler ;-)
Yes, it always surprises me how many there are when the help is printed.
So the log message may want a bit of rewrite in the title and the
introductory part, with a clarification that '?' is what we already
had and not what this adds (from Patrick's comment), and there may
be other small improvements we want to see that I may have missed,
but other than these small-ish points, the basic direction of this
patch is good?
I think so.
This is a tangent, but I think we _mostly_ take these commands case
insensitively (e.g., you can say 'Q' to quit the program, as well as
'q' that is listed above). But 'k' and 'j' (there may be others)
act differently when given in the uppercase.
'J' and 'K' are the only keys where we have different actions for upper
and lowers cases. The implementation looks a bit confused though - we
treat y,n,q,a,d case insensitively but not g,s,e,p. As no one has
complained about the latter we should perhaps leave them as is in case
we ever want to add upper case variants.
This would limit our
ability to later add capitalized variant of an already used lower
case letter without retraining users---should we find it disturbing,
or is "add -p" mostly done and we do not have to worry?
I think its mostly done. I'd like a way of selecting lines from a hunk
that does not involve making the user edit the hunk and I wish the
search remembered the last string but I don't think we're in danger of
running out of keys for new commands.
Best Wishes
Phillip
