On 2024.03.18 12:47, Mohit Marathe via GitGitGadget wrote: > From: Mohit Marathe <mohitmarathe@xxxxxxxxx> > > This patch replaces the code, that changes the path separators, > with the already existing function `change_path_separators()` > > Signed-off-by: Mohit Marathe <mohitmarathe@xxxxxxxxx> > --- > t/unit-tests/test-lib.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/t/unit-tests/test-lib.c b/t/unit-tests/test-lib.c > index 66d6980ffbe..b0e26263046 100644 > --- a/t/unit-tests/test-lib.c > +++ b/t/unit-tests/test-lib.c > @@ -52,9 +52,7 @@ static const char *make_relative(const char *location) > prefix_len = len - needle_len; > if (prefix[prefix_len + 1] == '/') { > /* Oh, we're not Windows */ > - for (size_t i = 0; i < needle_len; i++) > - if (needle[i] == '\\') > - needle[i] = '/'; > + change_path_separators(&needle[0]); Why not just: change_path_separators(needle); ? > need_bs_to_fs = 0; > } else { > need_bs_to_fs = 1; > @@ -88,9 +86,8 @@ static const char *make_relative(const char *location) > > /* convert backslashes to forward slashes */ > strlcpy(buf, location + prefix_len, sizeof(buf)); > - for (p = buf; *p; p++) > - if (*p == '\\') > - *p = '/'; > + p = buf; > + change_path_separators(p); And here, why not: change_path_separators(buf) ? > return buf; > } > > -- > gitgitgadget >