From: Max Gautier <mg@xxxxxxxxxxxxxxxx> To: git@xxxxxxxxxxxxxxx Cc: Lénaïc Huard <lenaic@xxxxxxxxx>, Derrick Stolee <stolee@xxxxxxxxx> Bcc: Reply-To: Subject: [RFC PATCH 0/5] maintenance: use packaged systemd units In-Reply-To: Hello, This is a proposal to distribute the timers of the systemd scheduler of git-maintenance directly, rather than inlining them into the code and writing them on demand. IMO, this is better than using the user $XDG_CONFIG_HOME, and allows that user to override them if they so wish. It's also less code. We also move away from using the random minute, and instead rely on systemd features to achieve the same goal (see patch 2). This allows us to go back to using unit templating for the timers. (Not that even if we really more specific OnCalendar= settings for each timer, we should still do it that way, but instead distribute override alongside the template, i.e /usr/lib/systemd-user/git-maintenance@daily.timer.d/override.conf: [Timer] OnCalendar=<specific calender spec for daily> The cleanup code for the units written in $XDG_CONFIG_HOME is adapted, and takes care of not removing legitimate user overrides, by checking the file start. Patch 5 removes the cleanup code, it should not be applied right away, but once enough time has passed and we can be reasonably sure that no one still has the old units laying around. Testing: Best way to approximate having the systemd units in /usr/lib would be to either : - sudo cp systemd/user/git-maintenance* /etc/systemd/user/ - sudo systemctl link --global systemd/user/git-maintenance* -> it's not exactly the same when enabling the you'll have a link in $XDG_CONFIG_HOME to your git source directory, so if you re-run `git start maintenance with the previous code, it will change your source. IMO the first method is less confusing. Unresolved (reasons why it's still an RFC): - Should I implement conditional install of systemd units (if systemd is available) ? I've avoided digging too deep in the Makefile, but that's doable, I think. --- Documentation/git-maintenance.txt | 33 ++-- Makefile | 4 + builtin/gc.c | 279 ++-------------------------------- systemd/user/git-maintenance@.service | 17 +++ systemd/user/git-maintenance@.timer | 12 ++ 5 files changed, 63 insertions(+), 282 deletions(-)
