Re: [PATCH v3 0/3] Assorted improvements salvaged from an earlier series

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Eric,

On 2024-03-25 21:54, Dragan Simic wrote:
On 2024-03-25 21:49, Eric Sunshine wrote:
On Mon, Mar 25, 2024 at 4:41 PM Dragan Simic <dsimic@xxxxxxxxxxx> wrote:
On 2024-03-25 21:39, Eric Sunshine wrote:
> Prose description of the changes between versions is very much welcome
> by reviewers, but please also include a range-diff[1] or interdiff[2]
> when preparing a reroll.

Ah, sorry, I didn't forget about that, but I just intended to start
providing range-diffs for future patches.  These were more like new
versions of old patches.

The range-diff is particularly valuable exactly for this case (new
versions of old patches) since it is a "diff" between the old patches
and the new patches. Thus, it provides reviewers with a precise
summary of what changed between, say, v2 and v3 of a series, and
manifests as a concrete representation of what your prose explanation
describes.

I see, and I do understand the purpose of range-diffs:  they make
reviewing new patch versions significantly easier, by relieving the
reviewers from the need to track down what has been changed in the
current patch version.

As a note, I kept my promise :) and have started providing range-diffs
in patch submissions. [1]

[1] https://lore.kernel.org/git/e3212c0a4ad331685c68c13afcdbced20982ab32.1712364420.git.dsimic@xxxxxxxxxxx/T/#u




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux