2024-03-28 22:38 skrev Eric Sunshine:
Nit: The comment doesn't tell the reader anything that the code itself isn't already clearly telling the reader, thus the comment is redundant and unnecessary. Moreover, the comment is likely to become outdated when people adjust the code but forget to update the comment. As such, I'd recommend dropping the comment altogether.
Yes, that does make sense. I copied the code for invoking "git show" from builtin/notes.c, which does have that type of redundant comment.
I'll remove it. -- \\// Peter - http://www.softwolves.pp.se/
