On Wed, Mar 20, 2024 at 8:01 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > "Brian Lyles" <brianmlyles@xxxxxxxxx> writes: > >> To me, this initially sounded like it meant "your patch was not >> something that the git maintainers would be interested in accepting". I >> *suspect* that what is actually meant here is "your patch was >> straightforward and non-controversial to the point that no members of >> the list saw it and felt the need to comment on it", though to be honest >> I am not 100% sure. > > I actually meant what I wrote. > > It is possible that the reason why your patch did not receive any > response was because it was uninspiring, looked useless, and did not > deserve anybody's attention. But it is also possible that it was > lost in the noise. > > And pinging on the topic by responding to your own message is not > just acceptable but very much appreciated way to remind others who > may have missed it, in case it is the latter. > > If a topic is truly obvious and straight-forward, it may be taken > silently to 'seen' and even to 'next', and since it is suggested for > the contributors to look at "master..seen", such a topic would not > fall into the "hear nothing about it from anybody for a long time" > category anyway. Thanks for the clarification. I do still think that a change in the wording and tone of this section could help make the project appear more friendly to new contributors. Phrases like "totally uninteresting", "uninspiring", "looked useless", and "did not deserve anybody's attention" are all fairly harsh sounding, even if sometimes true. Something more along the lines of "Mailing list members may not have seen the value of the proposed changes" or "Your patch may not have presented a convincing argument for being accepted" might land a little more gently and make someone more willing to make another attempt at a more compelling patch rather than feeling harshly rejected and leaving with a bad taste in their mouth about the project like has happened in the past [1]. [1]: https://lore.kernel.org/git/xmqq7ck7x10y.fsf@gitster.g/ Simply food for thought from someone relatively new to the list. -- Thank you, Brian Lyles
