On Wed, Mar 20, 2024 at 12:37:22PM -0400, Eric Sunshine wrote: > I have some vague feeling that this idea of using an environment > variable as a condition may have been discussed before and possibly > rejected due to potential security concerns, but I don't use > `includeif` myself and haven't really followed past discussions, so I > could be wrong about that. Peff would probably have better > recollection. I can't think of any security concerns; if you can control the environment you can already set GIT_CONFIG_PARAMETERS to do whatever you like. In fact, I think I've suggested includeIf.env before. ;) Ævar even wrote a patch, but I think we got bogged down in issues of syntax: https://lore.kernel.org/git/patch-1.1-1fe6f60d2bf-20210924T005553Z-avarab@xxxxxxxxx/ -Peff