On 2024-03-05 16:32, Junio C Hamano wrote:
"Kristoffer Haugsbakk" <code@xxxxxxxxxxxxxxx> writes:
I think this is more about `git config --add` not doing any
validation. It just sets things. You can do `git config --add
core.commentChar 'ffd'` and get the same effect.
As you said, we should document core.commentChar as limited to an
ASCII character, at least as a short term solution.
I personally do not see a reason, however, why we need to be limited
to a single byte, though. If a patch cleanly implements to allow us
to use any one-or-more-byte sequence as core.commentChar, I do not
offhand see a good reason to reject it---it would be fully backward
compatible and allows you to use a UTF-8 charcter outside ASCII, as
well as "//" and the like.
May I ask why would we want the comment character to possibly be
a multibyte character? I mean, I support localization, to make it all
easier for the users who opt not to use English, but wouldn't allowing
multibyte characters for the comment character simply be a bit unneeded?
Maybe I'm missing something?
