Op di 20 feb 2024 om 02:59 schreef Jeff King <peff@xxxxxxxx>: > All that said, I'm not sure based on our previous discussion why we > can't just call stream_blob_to_fd(). Looking at show_blob_object(), most > of the logic is about recording the tree-context of the given name and > using it for textconv. But since we know we are feeding a bare oid, > that would never kick in. So I don't know if there's any value in > sharing this function more widely in the first place. Indeed. My original analysis of what `git show` does when invoked by `git notes show` led to the conclusion that the only thing worthwhile to keep is the `setup_pager()` call. Thanks for confirming this. I'll reroll in a couple of days with the V1 approach back. Maarten
