Maarten Bosmans <mkbosmans@xxxxxxxxx> writes: > Subject: Re: [PATCH v2 1/5] log: Move show_blob_object() to log.c "Move" -> "move". > From: Maarten Bosmans <mkbosmans@xxxxxxxxx> > > From: Maarten Bosmans <maarten.bosmans@xxxxxxxxxx> The earlier one is not needed. Please do not include such a line. > > This way it can be used outside of builtin/log.c. > The next commit will make builtin/notes.c use it. The resulting file is only about a small part of the implementation detail of "show", and has very little to do with "log". "show.c" that happens to house show_blob_object(), a "canonical" way to display a blob object, with an anticipation that somebody may want to expand it in the future to house the "canonical" way to display a tag, a tree or a commit object, would be OK, though.