On Tue, Feb 13, 2024 at 6:21 PM Linus Arver <linusa@xxxxxxxxxx> wrote: > > Christian Couder <christian.couder@xxxxxxxxx> writes: > > > On Tue, Feb 6, 2024 at 6:12 AM Linus Arver via GitGitGadget > > <gitgitgadget@xxxxxxxxx> wrote: > > Also I wonder why it was not possible to modify format_trailer_info() > > like it is done in this patch before using it to replace > > format_trailers(). > > The artificial organization apparent in this patch was deliberate, in > order to make it painfully obvious exactly what was being replaced and > how. See https://lore.kernel.org/git/xmqqjzno13ev.fsf@gitster.g/ As for the previous patch, I would have thought that it would be better not to break the tests.
