On Tue, Feb 6, 2024 at 6:12 AM Linus Arver via GitGitGadget <gitgitgadget@xxxxxxxxx> wrote: > > From: Linus Arver <linusa@xxxxxxxxxx> > > Do not hardcode the printing of ": " as the separator and space (which > can result in double-printing these characters); instead only > print the separator and space if we cannot find any recognized separator > somewhere in the key (yes, keys may have a trailing separator in it --- > we will eventually fix this design but not now). Do so by copying the > code out of print_tok_val(), and deleting the same function. > > The test suite passes again with this change. I think it should be clearer above that this fixes a bug that was introduced earlier in the series. Also I wonder why it was not possible to modify format_trailer_info() like it is done in this patch before using it to replace format_trailers().