On Wed, Feb 7, 2024 at 11:48 AM Johannes Schindelin via GitGitGadget <gitgitgadget@xxxxxxxxx> wrote: > Always check `parse_tree*()`'s return value If you happen to reroll for some reason, perhaps: s/Always/always/ > Otherwise we may easily run into serious crashes: For example, if we run > `init_tree_desc()` directly after a failed `parse_tree()`, we are > accessing uninitialized data or trying to dereference `NULL`. > > Note that the `parse_tree()` function already takes care of showing an > error message. The `parse_tree_indirectly()` and > `repo_get_commit_tree()` functions do not, therefore those latter call > sites need to show a useful error message while the former do not. > > Signed-off-by: Johannes Schindelin <johannes.schindelin@xxxxxx>
