Re: [PATCH v3 4/4] for-each-ref: avoid filtering on empty pattern

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v3 4/4] for-each-ref: avoid filtering on empty pattern
From: Karthik Nayak <karthik.188@xxxxxxxxx>
Date: Wed, 7 Feb 2024 18:02:34 +0100
Cc: Phillip Wood <phillip.wood123@xxxxxxxxx>, phillip.wood@xxxxxxxxxxxxx, git@xxxxxxxxxxxxxxx, ps@xxxxxx
In-reply-to: <xmqq1q9ocje3.fsf@gitster.g>
References: <20240119142705.139374-1-karthik.188@gmail.com> <20240129113527.607022-1-karthik.188@gmail.com> <20240129113527.607022-5-karthik.188@gmail.com> <98d79d33-0d7e-4a9c-a6a3-ed9b58cd7445@gmail.com> <CAOLa=ZR=_tt=ppphGMkxqj_YB5G+YkTMWGzRzcHTbrZz4ysb5w@mail.gmail.com> <92ba680d-0b48-49f0-aafc-f503e5a5e0ea@gmail.com> <xmqqle7xjzic.fsf@gitster.g> <xmqqr0hph1ku.fsf@gitster.g> <CAOLa=ZSZJ=_VCppHXcJeE=Z61go4_040xyc1NBTu-o=xysLrdg@mail.gmail.com> <xmqqcyt9fdc7.fsf@gitster.g> <CAOLa=ZRcWYmEYnxh_=ykOerahZ61xaanLCj_JHHLvtrvN=Xs-w@mail.gmail.com> <xmqq1q9oe029.fsf@gitster.g> <CAOLa=ZQzz7_L_9cBmK+pgFwd_DFqfWDVRiaZMAxU+54kBq6Pcw@mail.gmail.com> <xmqq1q9ocje3.fsf@gitster.g>

On Wed, Feb 7, 2024 at 5:46 PM Junio C Hamano <gitster@xxxxxxxxx> wrote:
>
> Karthik Nayak <karthik.188@xxxxxxxxx> writes:
>
> > This is a bit of a grey area, what I mean is that we do allow users to create
> > non "refs/" prefixed refs:
> >
> >     $ git update-ref foo @~1
> >
> >     $ cat .git/foo
> >     2b52187cd2930931c6d34436371f470bb26eef4f
> >
> > What I mean to say is that, by saying "--include-root-refs" it seems to imply
> > that any such refs should be included too, but this simply is not the case.
>
> But isn't that a quality of implementation issue?  I'd consider it a
> bug once we have and enforce the definition of what pseudorefs are.

Yeah, that makes sense. I'll use "--include-root-refs" then.

Thanks

Follow-Ups:
- Re: [PATCH v3 4/4] for-each-ref: avoid filtering on empty pattern
  - From: Patrick Steinhardt

References:
- [PATCH 0/5] for-each-ref: print all refs on empty string pattern
  - From: Karthik Nayak
- [PATCH v3 0/4] for-each-ref: print all refs on empty string pattern
  - From: Karthik Nayak
- [PATCH v3 4/4] for-each-ref: avoid filtering on empty pattern
  - From: Karthik Nayak
- Re: [PATCH v3 4/4] for-each-ref: avoid filtering on empty pattern
  - From: Phillip Wood
- Re: [PATCH v3 4/4] for-each-ref: avoid filtering on empty pattern
  - From: Karthik Nayak
- Re: [PATCH v3 4/4] for-each-ref: avoid filtering on empty pattern
  - From: Phillip Wood
- Re: [PATCH v3 4/4] for-each-ref: avoid filtering on empty pattern
  - From: Junio C Hamano
- Re: [PATCH v3 4/4] for-each-ref: avoid filtering on empty pattern
  - From: Junio C Hamano
- Re: [PATCH v3 4/4] for-each-ref: avoid filtering on empty pattern
  - From: Karthik Nayak
- Re: [PATCH v3 4/4] for-each-ref: avoid filtering on empty pattern
  - From: Junio C Hamano
- Re: [PATCH v3 4/4] for-each-ref: avoid filtering on empty pattern
  - From: Karthik Nayak
- Re: [PATCH v3 4/4] for-each-ref: avoid filtering on empty pattern
  - From: Junio C Hamano
- Re: [PATCH v3 4/4] for-each-ref: avoid filtering on empty pattern
  - From: Karthik Nayak
- Re: [PATCH v3 4/4] for-each-ref: avoid filtering on empty pattern
  - From: Junio C Hamano

Prev by Date: Re: [PATCH v2 1/5] merge-tree: fail with a non-zero exit code on missing tree objects
Next by Date: Re: [PATCH v2] commit.c: ensure find_header_mem() doesn't scan beyond given range
Previous by thread: Re: [PATCH v3 4/4] for-each-ref: avoid filtering on empty pattern
Next by thread: Re: [PATCH v3 4/4] for-each-ref: avoid filtering on empty pattern
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]