On Fri, Feb 02, 2024 at 05:32:42PM -0800, Junio C Hamano wrote: > Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: > > > The line 753 of that file (as can be seen at > > https://github.com/git/git/blob/38aa6559b0c513d755d6d5ccf32414ed63754726/config.mak.uname#L753) > > Ouch. When it is laid out like this it is very obvious why this is > broken, and what its workaround should be. > > Thanks. Let's queue this on top. > > ------- >8 ------------- >8 ------------- >8 ------------- >8 ------- > Subject: [PATCH] t/Makefile: say the default target upfront > > Similar to how 2731d048 (Makefile: say the default target upfront., > 2005-12-01) added the default target to the very beginning of the > main Makefile to prevent a random rule that happens to be defined > first in an included makefile fragments from becoming the default > target, protect this Makefile the same way. > > This started to matter as we started to include config.mak.uname > and that included makefile fragment does more than defining Make > macros, unfortunately. > > Helped-by: Johannes Schindelin <johannes.schindelin@xxxxxx> > Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx> Thanks both of you for identifying and fixing this. I should have been able to catch this, as it triggers with a simple "make" in the t/ directory (rather than "make prove" or "make unit-test", which is of course what I checked). Sorry I'm slow to chime in; I've been offline all week (and probably will be for another few days) due to a family emergency. But hopefully with this fix the topic is OK now. -Peff
