On Wed, Jan 31, 2024 at 02:44:38PM +0100, Toon Claes wrote: > > Patrick Steinhardt <ps@xxxxxx> writes: > > > When finishing the current section we may end up writing index records > > for the section to the table. The logic to do so essentially copies what > > we already have in `writer_add_record()`, making this more complicated > > than it really has to be. > > I didn't feel like this commit message made it easier for me to > understand, because I interpreted words differently than you intended. > Using "may end up" makes it sound like it's unexpected behavior. Also > the use of "copies" implies to me it's doing a copy operation. I would > rephrase it to something like: > > When finishing the current section some index records might be written > for the section to the table. The logic to do so is essentially > duplicated from what we already have in `writer_add_record()`, making > this more complicated than it really has to be. > > Other than that, I don't have any comments about this patch series. Thanks, I'll use a slightly adapted version of this. Patrick
Attachment:
signature.asc
Description: PGP signature
