Re: [PATCH 3/5] reftable/writer: simplify writing index records

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi

It looks like this isn’t in `next` yet so I’ll leave a comment.

> @@ -405,6 +405,7 @@ static int writer_finish_section(struct reftable_writer *w)
>  		w->index = NULL;
>  		w->index_len = 0;
>  		w->index_cap = 0;
> +

This part and the next quoted one seem to be an unrelated edit by
`clang-format`. They could perhaps be grouped in their own patch.

> -				abort();
> -			}
>  		}
> -		for (i = 0; i < idx_len; i++) {
> +
> +		for (i = 0; i < idx_len; i++)
>  			strbuf_release(&idx[i].last_key);
> -		}
>  		reftable_free(idx);
>  	}

-- 
Kristoffer Haugsbakk





[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux