Dan McGee <dpmcgee@xxxxxxxxx> writes: > Commit 889a50e909dba5f4416049afc5eeae601fe133bc changed several `` to $() > format for command substitution, so we should standardize on one format > for clarity. > ... > @@ -203,7 +203,7 @@ do > -s|--s|--st|--str|--stra|--strat|--strate|--strateg|--strategy) > case "$#,$1" in > *,*=*) > - strategy=`expr "z$1" : 'z-[^=]*=\(.*\)'` ;; > + strategy=$(expr "z$1" : 'z-[^=]*=\(.*\)'` ;) > 1,*) > usage ;; > *) The patch might have meant well, but it is a rather unnecessary code churn without fixing anything and introducing a bug X-<. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html